On Mon, 11 Mar 2024 15:00:21 GMT, Tejesh R <t...@openjdk.org> wrote:
>> Convert javax/swing/border/Test4129681.java applet test to main based test
>> using PassFailJFrame.
>
> Tejesh R has updated the pull request incrementally with three additional
> commits since the last revision:
>
> - Review updates
> - Review updates
> - Updates
Changes requested by aivanov (Reviewer).
Marked as reviewed by aivanov (Reviewer).
test/jdk/javax/swing/border/Test4129681.java line 41:
> 39:
> 40: public class Test4129681 {
> 41: private static JLabel label;
The `label` does not need to be global, it can be confined to `init`.
test/jdk/javax/swing/border/Test4129681.java line 47:
> 45: public static void main(String[] args) throws Exception {
> 46: String testInstructions = """
> 47: When frame starts, you'll see a checkbox
It's not what I really meant.
The instructions and the frame appear simultaneously, thus the tester doesn't
need to wait for anything. Just describe what the tester needs to do.
test/jdk/javax/swing/border/Test4129681.java line 53:
> 51: is disabled as well as the label.
> 52: """;
> 53: PassFailJFrame passFailJFrame = new PassFailJFrame.Builder()
Suggestion:
PassFailJFrame passFailJFrame = PassFailJFrame.builder()
Use helper method to create the builder, don't use `new` explicitly.
-------------
PR Review: https://git.openjdk.org/jdk/pull/18189#pullrequestreview-1928044311
PR Review: https://git.openjdk.org/jdk/pull/18189#pullrequestreview-1928078877
PR Review Comment: https://git.openjdk.org/jdk/pull/18189#discussion_r1519870582
PR Review Comment: https://git.openjdk.org/jdk/pull/18189#discussion_r1519849859
PR Review Comment: https://git.openjdk.org/jdk/pull/18189#discussion_r1519855420
