On Mon, 11 Mar 2024 17:29:50 GMT, Alexander Zvegintsev <azveg...@openjdk.org> wrote:
> The `java/awt/FileDialog/RegexpFilterTest/RegexpFilterTest` test is written > to test the very specific functionality of `XFileDialogPeer`, so it shouldn't > be run on platforms other than Linux. > > We also need to set `sun.awt.disableGtkFileDialogs` to `true` to be able to > test `XFileDialogPeer`, because by default it tries to use the Gtk file > dialog if it is available. > The Gtk file dialog has a search field hidden under the magnifying glass > icon, but it has a different syntax. > > The Windows system file dialog allows you to use wildcard filtering in the > "File name" field by hitting the `enter` afterwards, but again, this test was > written to test our own file dialog implementation, not the system's. Changes requested by aivanov (Reviewer). test/jdk/ProblemList.txt line 799: > 797: java/awt/TrayIcon/DragEventSource/DragEventSource.java 8252242 macosx-all > 798: java/awt/FileDialog/DefaultFocusOwner/DefaultFocusOwner.java 7187728 > macosx-all,linux-all > 799: java/awt/FileDialog/RegexpFilterTest/RegexpFilterTest.html 7187728 > macosx-all,linux-all What about [JDK-7187728](https://bugs.openjdk.org/browse/JDK-7187728)? It's still unresolved. test/jdk/java/awt/FileDialog/RegexpFilterTest.java line 73: > 71: .build(); > 72: > 73: passFailJFrame.awaitAndCheck(); Suggestion: .build() .awaitAndCheck(); Chain it. Then the variable `passFailJFrame` becomes redundant. test/jdk/java/awt/FileDialog/RegexpFilterTest/RegexpFilterTest.java line 1: > 1: /* I believe we haven't flattened the directory structure when modifying tests. On the other hand, this file has no meaningful modification history, so nothing's lost. ------------- PR Review: https://git.openjdk.org/jdk/pull/18203#pullrequestreview-1929348959 PR Review Comment: https://git.openjdk.org/jdk/pull/18203#discussion_r1520449595 PR Review Comment: https://git.openjdk.org/jdk/pull/18203#discussion_r1520446796 PR Review Comment: https://git.openjdk.org/jdk/pull/18203#discussion_r1520448130
