On Tue, 12 Mar 2024 00:35:24 GMT, Alisen Chung <[email protected]> wrote:
>> Removing applet usage from manual JColorChooser tests > > Alisen Chung has updated the pull request incrementally with five additional > commits since the last revision: > > - fix pfjframe builder styling and jtreg manual tag > - revert spacing > - revert files > - restore file > - revert file test/jdk/javax/swing/JColorChooser/Test4222508.java line 35: > 33: * @build PassFailJFrame > 34: * @summary Tests the color chooser disabling > 35: * @run main Test4222508 This needs to specify the test is manual. test/jdk/javax/swing/JColorChooser/Test4222508.java line 47: > 45: .testTimeOut(10) > 46: .rows(5) > 47: .columns(40) A style thing but since rows + columns apply to the instruction window I think they should go right after .instructions test/jdk/javax/swing/JColorChooser/Test4319113.java line 47: > 45: * @build PassFailJFrame > 46: * @summary Tests the open JColorChooser behavior on LaF change. > 47: * @run main Test4319113 This needs to specify the test is manual. test/jdk/javax/swing/JColorChooser/Test4319113.java line 58: > 56: .testTimeOut(10) > 57: .rows(5) > 58: .columns(40) same style comment ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18209#discussion_r1520604494 PR Review Comment: https://git.openjdk.org/jdk/pull/18209#discussion_r1520606750 PR Review Comment: https://git.openjdk.org/jdk/pull/18209#discussion_r1520605090 PR Review Comment: https://git.openjdk.org/jdk/pull/18209#discussion_r1520610670
