On Tue, 12 Mar 2024 00:37:37 GMT, Alisen Chung <[email protected]> wrote:
>> Removing applet usage from manual JColorChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix pfjframe builder styling and jtreg manual tag
test/jdk/javax/swing/JColorChooser/Test4319113.java line 53:
> 51: PassFailJFrame.builder()
> 52: .title("Test4319113")
> 53: .instructions("Choose a LaF using the dropdown. Click on
> the Show JColorChooser button.\n" +
I feel its better to use a separate String variable for Test instructions and
then use it here.
test/jdk/javax/swing/JColorChooser/Test4319113.java line 65:
> 63:
> 64: private static JFrame test() {
> 65: JFrame frame = new JFrame("Test4319113");
Title can be something like "JColorChooser behavior test".
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18210#discussion_r1520870884
PR Review Comment: https://git.openjdk.org/jdk/pull/18210#discussion_r1520869172
