On Wed, 13 Mar 2024 07:54:12 GMT, Prasanta Sadhukhan <[email protected]> wrote:
>> test/jdk/javax/swing/JOptionPane/bug8024926.java line 46: >> >>> 44: Verify that high resolution system icons are used >>> 45: in JOptionPane on HiDPI displays. >>> 46: 1) Run the test on Retina display or enable the Quartz >>> Debug >> >> Quartz debug ? How ? And we don't even use Quartz. >> The pass criteria is completely subjective. >> So this test looks like it needs to be better. >> If you can't figure out a better test for this in less than a day just >> delete this useless thing. > > I can remove the "Quartz debug" portion if it is not applicable, but as you > know, it's a straight lift from the existing instructions...The reviewer that > time did not object to this phrase it seems (was it used that time and > subsequently revoked later?) > https://hg.openjdk.org/jdk9/jdk9/jdk/rev/4991a758abef > > Also, the product fix has another test > `test/javax/swing/JMenuItem/8031573/bug8031573.java` which also put the > same pass criteria that icons should be smooth and our manual testing team > has not made any objections to the instructions of both test it seems.. It looks like Quartz is still used in some native image handling code. OK. If the instruction is harmless let it stay, but I doubt anyone does that. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18232#discussion_r1524053294
