On Thu, 14 Mar 2024 12:39:40 GMT, Abhishek Kumar <abhis...@openjdk.org> wrote:
>> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Minor fixes > > test/jdk/java/awt/Choice/NonFocusablePopupMenuTest.java line 46: > >> 44: Choice choice; >> 45: Point pos; >> 46: Dimension size; > > Should we declare `Point` and `Dimesnion` variable as volatile? Fixed. > test/jdk/java/awt/Choice/NonFocusablePopupMenuTest.java line 84: > >> 82: dispose(); >> 83: }); >> 84: if (choice.getSelectedIndex() == selected) { > > `choice.getSelectedIndex()` accessed outside EDT. Fixed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18300#discussion_r1525038508 PR Review Comment: https://git.openjdk.org/jdk/pull/18300#discussion_r1525037673