On Wed, 13 Mar 2024 18:49:03 GMT, Harshitha Onkar <hon...@openjdk.org> wrote:
> java/awt/font/TextLayout/TestJustification.html is converted to main manual > test using PassFailJFrame. > > This test was previously problemlisted on macOS. When tested on macOS, the > problem still exists and not all lines are justified to the same length > (lines containing Arabic & Hebrew differ by a small amount, Refer > [JDK-8250791](https://bugs.openjdk.org/browse/JDK-8250791)). For this reason, > the test is retained in problemlist and the file extension in problemlist is > changed to .java to match the test changes. Looks good except for a minor comment. test/jdk/java/awt/font/TextLayout/TestJustification.java line 77: > 75: > 76: private static JFrame createUI() { > 77: JFrame frame= new JFrame("Test Text Justification"); You probably want to use `Frame` instead of `JFrame` since `JustificationPanel` is an AWT component. ------------- Marked as reviewed by aivanov (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/18285#pullrequestreview-1937403627 PR Review Comment: https://git.openjdk.org/jdk/pull/18285#discussion_r1525297032
