On Thu, 14 Mar 2024 00:23:01 GMT, Harshitha Onkar <[email protected]> wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8328021
>
> test/jdk/java/awt/List/SetFontTest.java line 55:
>
>> 53: .instructions(INSTRUCTIONS)
>> 54: .rows(10)
>> 55: .columns(60)
>
> Existing config looks too wide for the instructions.
>
> Suggestion:
>
> .columns(35)
35 seems too tight - 40 looks better
> test/jdk/java/awt/List/SetFontTest.java line 74:
>
>> 72:
>> 73: button1.addActionListener(
>> 74: new ActionListener(){
>
> It can be shortened with lambda
hmm, yes, but not necessary for porting the test.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18255#discussion_r1525339013
PR Review Comment: https://git.openjdk.org/jdk/pull/18255#discussion_r1525340562
