On Thu, 14 Mar 2024 21:27:47 GMT, Phil Race <p...@openjdk.org> wrote:
> After some experimentation/thought I think it best to delete this applet test. > > It is supposed to be a manual test but is missing the manual keyword so > as far as I can tell it has never been usefully run. Except perhaps a few > times > when first being verified. > When I run it in jtreg a window popups up, disappears and the test is passed > Contradicting instructions in the test that tell you it has to be manual > because > you need to run it *in the browser* not jtreg. > > Well, we don't support browser applets any more. > And the scenario it was testing was explicitly a case that happened with the > browser. > > And to cap it all, I see no way for you to tell jtreg that it passed or > failed - because > you run it in the browser. > > So it is manual in the sense that it is NOT a jtreg test and so it should not > even have > an @test tag. > > These are more than enough reasons to just delete it. It was originally meant for browser applet which as you told is not supported and therefore test can be removed but I see it is also used to test a Unity fix for [8159460](https://bugs.openjdk.org/browse/JDK-8159460) that does not seem to be about applet, rather undecorated child window not getting focus... Yet the test instructions is being done in SecurityException catch-block which itself looks odd...Guess it's fair enough to delete.. ------------- Marked as reviewed by psadhukhan (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/18314#pullrequestreview-1938093291
