On Mon, 18 Mar 2024 15:39:52 GMT, Alexander Zvegintsev <azveg...@openjdk.org> wrote:
>> test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 55: >> >>> 53: >>> 54: public static void main (String[] args) throws Exception { >>> 55: PassFailJFrame.builder() >> >> OS check can be added. >> https://github.com/openjdk/jdk/pull/18233#discussion_r1525227378 > > It can be added, but I see no reason to do so. > > It may be helpful for tests that can be run standalone (that don't respect > the jtreg tags and depend on some other jtreg libraries), but for this one > the only easy way to run it is through jtreg, so the `@requires (os.family == > "windows")` is sufficient. I agree with @azvegint, since it has @requires check in jtreg and the test will mainly be run using jtreg framework , the OS check is not strictly required. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1528977895