On Wed, 20 Mar 2024 18:57:37 GMT, Phil Race <[email protected]> wrote:
>> Convert this applet based test to a main program
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8328301
test/jdk/java/awt/datatransfer/HTMLDataFlavors/ManualHTMLDataFlavorTest.java
line 110:
> 108: } catch (UnsupportedFlavorException | IOException e) {
> 109: e.printStackTrace();
> 110: }
Should exception make the test fail?
test/jdk/java/awt/datatransfer/HTMLDataFlavors/ManualHTMLDataFlavorTest.java
line 123:
> 121: the browser to other applications because of,
> 122: the protected mode restrictions.,
> 123: On Mac OS X do NOT use Safari, it does not provide the needed
> DataFlavor,
Suggestion:
IMPORTANT NOTE: the page should be stored locally.
Otherwise, for instance iexplore, can prohibit drag and drop from
the browser to other applications because of
the protected mode restrictions.
On Mac OS X do NOT use Safari, it does not provide the needed
DataFlavor.
The commas in the end of each line seem to come from the commas separating
items in an array of Strings. I'm for removing those commas to avoid any
confusion when reading the instructions.
test/jdk/java/awt/datatransfer/HTMLDataFlavors/ManualHTMLDataFlavorTest.java
line 126:
> 124: 3) Check the data in the output area of this window,
> 125: 5) The output should not contain information that any of,
> 126: flavors is not present in the system clipboard,
I believe this condition can be verified automatically. If any missing data
flavour should result in test failure, the test could be failed with
`PassFailJFrame.forceFail`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18334#discussion_r1534117514
PR Review Comment: https://git.openjdk.org/jdk/pull/18334#discussion_r1534123447
PR Review Comment: https://git.openjdk.org/jdk/pull/18334#discussion_r1534128423
