On Wed, 20 Mar 2024 15:48:41 GMT, Alexander Zuev <kiz...@openjdk.org> wrote:
>> Convert test to main manual;
>> Move test to appropriate folder;
>> Delete old files;
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Moving test metadata closer to the class definition for better readability;
> Making test automatically skip execution on unsuported toolkit;
> Eliminated the separate frame, moving button inside the PassFailJFrame;
> Corrected test instructions accordingly;
Marked as reviewed by azvegint (Reviewer).
test/jdk/java/awt/FileDialog/FileDialogOpenDirTest.java line 49:
> 47: JButton open = new JButton("Open File Dialog");
> 48: open.addActionListener(e -> {
> 49: new FileDialog((Frame) null).show();
Suggestion:
new FileDialog((Frame) null).setVisible(true);
show is deprecated
test/jdk/java/awt/FileDialog/FileDialogOpenDirTest.java line 68:
> 66: if (!toolkit.equals("sun.awt.X11.XToolkit")) {
> 67: throw new SkippedException("Test is not designed for toolkit
> " + toolkit);
> 68: }
Cay be moved to the beginning of the main, to bail out early.
-------------
PR Review: https://git.openjdk.org/jdk/pull/18361#pullrequestreview-1952775158
PR Review Comment: https://git.openjdk.org/jdk/pull/18361#discussion_r1534257573
PR Review Comment: https://git.openjdk.org/jdk/pull/18361#discussion_r1534258864
