On Thu, 21 Mar 2024 10:46:41 GMT, Abhishek Kumar <[email protected]> wrote:

> Few manual closed applet test converted to automated and open sourced.

Marked as reviewed by psadhukhan (Reviewer).

test/jdk/javax/swing/JInternalFrame/Ctrli.java line 126:

> 124:         keyecho.addMouseListener(mouseListener);
> 125:         frame.setLayout(new BorderLayout());
> 126:         frame.getContentPane().add(keyecho);

getContentPane is obsolete since jdk1.5 so can be removed as per this 
[comment](https://github.com/openjdk/jdk/pull/18390#discussion_r1533017080)

test/jdk/javax/swing/JMenuItem/JActionCommandTest.java line 135:

> 133:         mb.add(m);
> 134:         f.setJMenuBar(mb);
> 135:         f.getContentPane().add("South", tf);

same as above..

-------------

PR Review: https://git.openjdk.org/jdk/pull/18428#pullrequestreview-1952802096
PR Review Comment: https://git.openjdk.org/jdk/pull/18428#discussion_r1534273918
PR Review Comment: https://git.openjdk.org/jdk/pull/18428#discussion_r1534274838

Reply via email to