On Thu, 21 Mar 2024 17:13:34 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comments > > test/jdk/java/awt/image/multiresolution/MultiDisplayTest.java line 62: > >> 60: - 2nd display is non-HiDPI. >> 61: >> 62: In other cases please simply push "Pass". > > These conditions can be detected. On the other hand, since it's a manual > test, the tester could enable or connect a second monitor, so it makes sense > to preserve the instructions. Do we need an occasional _Skip_ button? Yet adding such a button to throw `jtreg.SkippedException` will introduce a transitive dependency on the library which contains the `SkippedException`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18354#discussion_r1534325241
