On Thu, 21 Mar 2024 17:52:34 GMT, Harshitha Onkar <hon...@openjdk.org> wrote:

>> Following test is converted from applet to main using PassFailJFrame.
>> 
>> The original test had ignore tag - **The fix for this problem was backed out 
>> for 5057184.  Remove this "ignore" tag when it is fixed again.**
>> I believe this was fixed and the test works correctly on Linux platforms, 
>> hence ignore tag has been removed.
>> 
>> This is a semi-automated test, the first check is manual and the 2nd one is 
>> automated. Details in the test instructions.
>
> Harshitha Onkar has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   minor jtreg tag change

Marked as reviewed by azvegint (Reviewer).

test/jdk/java/awt/im/bug4490692.java line 87:

> 85:         panel.add(new JLabel("Text field:"));
> 86: 
> 87:         textField.addKeyListener(new KeyListener() {

you can use `KeyAdapter` to avoid overriding unused methods (`keyTyped`, 
`keyReleased`).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18402#pullrequestreview-1953247310
PR Review Comment: https://git.openjdk.org/jdk/pull/18402#discussion_r1534565486

Reply via email to