On Thu, 21 Mar 2024 13:51:16 GMT, Alexander Zvegintsev <[email protected]> 
wrote:

>> Phil Race has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   8328642
>
> test/jdk/java/awt/List/MouseDraggedOutCauseScrollingTest/MouseDraggedOutCauseScrollingTest.java
>  line 31:
> 
>> 29:   @library /java/awt/regtesthelpers
>> 30:   @run main/manual MouseDraggedOutCauseScrollingTest
>> 31: */
> 
> We usually move this and instructions block closer to a class declaration, 
> for better readability.

So people have been saying this, and I've even done it when asked, but I'm not 
sure I agree.
Although it has to go below the legal stuff, after that I like to see the test 
tag right at the top of the file,
not below a random number of imports.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18414#discussion_r1534605049

Reply via email to