On Thu, 21 Mar 2024 19:10:40 GMT, Phil Race <[email protected]> wrote:
> This previously closed test is cleaned up, opened and fixed to work on hidpi
> at fractional scales.
> It has unrelated problems on macOS 14 and is problem listed there (as it was
> when it was a closed test).
test/jdk/java/awt/Dialog/JaWSTest.java line 70:
> 68: robot.mousePress(InputEvent.BUTTON1_DOWN_MASK);
> 69: robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK);
> 70: if (!worker.dialogFinished.await(5, TimeUnit.SECONDS)) {
Suggestion:
if (!dialogFinished.await(5, TimeUnit.SECONDS)) {
Since `dialogFinished` is static, it can be accessed directly, without the
`worker` object.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18439#discussion_r1535805618
