On Fri, 22 Mar 2024 22:15:48 GMT, Damon Nguyen <[email protected]> wrote:
>> Convert java/awt/print/Dialog/PrintApplet.java applet test to main using
>> PassFailJFrame. Also rename the test to PrintModalDialog.java since this is
>> no longer an applet. Added test instructions related to the linked JBS issue.
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Move tags
Updated changes look good. Updated Test Instructions clearer now.
test/jdk/java/awt/print/Dialog/PrintModalDialog.java line 67:
> 65: .title("PrintModalDialog Instructions")
> 66: .instructions(INSTRUCTIONS)
> 67: .rows(20)
Suggestion:
.rows((int) INSTRUCTIONS.lines().count() + 1)
-------------
Marked as reviewed by honkar (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18362#pullrequestreview-1955882723
PR Review Comment: https://git.openjdk.org/jdk/pull/18362#discussion_r1536278274
