On Sat, 23 Mar 2024 08:23:25 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> 
wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Move test out of extra dir
>
> test/jdk/java/awt/print/bug8023392.java line 116:
> 
>> 114:                 @Override
>> 115:                 protected void paintComponent(Graphics g) {
>> 116:                     SwingUtilities2.drawChars(this, g, s.toCharArray(),
> 
> cant we use `Graphics.drawChars` instead in all places 
> `SwingUtilities2.drawChars` is used?

`Graphics.drawChars` isn't a static method, which will require additional 
changes to this test. Is it preferred to use `Graphics` over the 
`SwingUtilities2` version?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18458#discussion_r1537844651

Reply via email to