On Mon, 25 Mar 2024 19:53:54 GMT, Damon Nguyen <dngu...@openjdk.org> wrote:
>> Convert >> java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html >> applet test to main using PassFailJFrame > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Fix spelling > @DamonGuy The test in #18362 and the one in this PR test similar > functionality -Dialog Modality when using Print functions. Will combining or > retaining only one test make more sense instead of 2 separate tests? Good point. This one was originally for windows only for print dialog and page dialog modality. The other PR was for web dialogs. They're also in different directories, one for `PrinterJob` and one for `Dialog`. They are similar though now. What do you suggest @honkar-jdk? I prefer this test overall over the other if I had to pick one. Cleaner and more succinct test. ------------- PR Comment: https://git.openjdk.org/jdk/pull/18461#issuecomment-2019116843
