On Mon, 25 Mar 2024 16:59:37 GMT, Alisen Chung <[email protected]> wrote:
>> Removing applet usage from manual JFileChooser tests >> The original test is failing (nothing shows up in the JFileChooser), but >> this change does replace the applet usage with PassFailJFrame > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > increase rows to show second window `rootFile`, `subdir `and `subdirFile` can be moved inside `VirtualFileSystemView` class ? test/jdk/javax/swing/JFileChooser/6698013/bug6698013.java line 52: > 50: 1. Go into 'subdir' folder via double click > 51: 2. Return to parent directory > 52: 3. Go into 'subdir' folder: select 'subdir' folder and > press the 'Open' button"""; Mentioning about Test Pass and Fail criteria would be beneficial, the instruction only says how to test, doesn't specify about Test PASS/FAIL criteria....? ------------- PR Review: https://git.openjdk.org/jdk/pull/18456#pullrequestreview-1959557433 PR Review Comment: https://git.openjdk.org/jdk/pull/18456#discussion_r1538727435
