On Thu, 25 Jan 2024 11:11:47 GMT, rjolly <d...@openjdk.org> wrote: > ChangedCharSetException is used to amend the charset during read according to > html directives. Currently it causes immediate exit of the method which in > turn causes failure to load html documents with charset directives (even if > the latter must not change after all). This PR restores the catch operation > as it was before the use of try with resources.
Your changeset looks good to me, it resolves the problem, the HTML stream is re-read with the correct charset and displays correctly. The test that I attached to JBS can be converted to a jtreg regression test and added to your PR. You should not force-push to a branch that's already on the review. If you want to update to latest master, use `git merge` to update the branch and then push it. ------------- PR Comment: https://git.openjdk.org/jdk/pull/17567#issuecomment-2018941633 PR Comment: https://git.openjdk.org/jdk/pull/17567#issuecomment-2020170003
