On Thu, 28 Mar 2024 01:06:32 GMT, Harshitha Onkar <hon...@openjdk.org> wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fight.gif added
>
> test/jdk/java/awt/Frame/FrameMinimizeTest.java line 36:
>
>> 34:
>> 35: public class FrameMinimizeTest {
>> 36: public static void main(String args[]) throws Exception {
>
> Java style arrays
Updated.
> test/jdk/java/awt/Frame/SizeMinimizedTest.java line 48:
>
>> 46: continuously be logged, so you can verify its
>> changes)
>> 47: 1. When the test starts, two frame windows will
>> appear.
>> 48: Note the size of frame2.
>
> Window listeners can be used to check the initial and subsequent frame size
> and positions. This avoids asking the user to keep note of these details.
>
> It could be potentially be automated at this point, if it doesn't require
> much effort.
>
>
>
> frame2.addWindowListener(new WindowAdapter() {
> @Override
> public void windowOpened(WindowEvent e) {
> PassFailJFrame.log("Initial Frame Size: " + frame2.getSize());
> PassFailJFrame.log("Initial Frame Location: " +
> frame2.getLocationOnScreen());
> }
> });
> frame2.addWindowStateListener(new WindowAdapter() {
> @Override
> public void windowStateChanged(WindowEvent e) {
> if (e.getNewState() == Frame.NORMAL) {
> PassFailJFrame.log("Frame Size: " + frame2.getSize());
> PassFailJFrame.log("Frame Location: " +
> frame2.getLocationOnScreen());
> }
> }
> });
Yeah, was able to automate the test. Thank you for the suggestion. In linux the
test fails intermittently though, might be linked to the issue
[JDK-8305915](https://bugs.openjdk.org/browse/JDK-8305915) so have problem
listed, which I have update the description.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18448#discussion_r1544311780
PR Review Comment: https://git.openjdk.org/jdk/pull/18448#discussion_r1544313163
