On Fri, 29 Mar 2024 14:37:42 GMT, Alisen Chung <ach...@openjdk.org> wrote:
>> Removing applet usage from manual JFileChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> move var into local, simplified condition check, spacing
Changes requested by honkar (Reviewer).
test/jdk/javax/swing/JFileChooser/4150029/bug4150029.java line 126:
> 124: clickBackSpace();
> 125:
> 126: if (prevDir == crntDir) {
Wrong comparison operator, it should be .equals() here.
You might want to run the CI testing again with the updated changes just to
make sure it works the same on all platforms.
Suggestion:
if (prevDir.equals(crntDir)) {
-------------
PR Review: https://git.openjdk.org/jdk/pull/18415#pullrequestreview-1972107056
PR Review Comment: https://git.openjdk.org/jdk/pull/18415#discussion_r1546837460
