On Fri, 5 Apr 2024 04:35:25 GMT, Tejesh R <t...@openjdk.org> wrote:

>> Convert and open source these manual applet test to main based:
>> java/awt/Frame/MegaIconTest/MegaIconTest.html
>> java/awt/Frame/FrameMaximizedTest/FrameMaximizedTest.html
>> java/awt/Frame/FrameMinimizeTest/FrameMinimizeTest.html
>> java/awt/Frame/SizeMinimizedTest/SizeMinimizedTest.html
>> 
>> Automated the test SizeMinimizedTest.java. Since the test is failing Linux 
>> arch (Maybe related to the bug - 
>> [JDK-8305915](https://bugs.openjdk.org/browse/JDK-8305915)), the test is 
>> problem listed for Linux arch until the issue is fixed/further investigation 
>> is done.
>
> Tejesh R has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Review comments updated - SizeMinimizedTest

Updated changes look good.

test/jdk/java/awt/Frame/SizeMinimizedTest.java line 60:

> 58:             });
> 59:             robot.waitForIdle();
> 60:             robot.delay(100);

The delay can be increased here since it is after createUI.

Suggestion:

            robot.delay(1000);

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18448#pullrequestreview-1983759081
PR Review Comment: https://git.openjdk.org/jdk/pull/18448#discussion_r1554031631

Reply via email to