On Tue, 9 Apr 2024 20:24:06 GMT, Phil Race <p...@openjdk.org> wrote: >> Because you didn't add the backticks <code>`</code> around your sample, it's >> interpreted as HTML, and I can't really see it. >> >> I guess, the code was something line this: `<span style='text-decoration: >> line-through'><s>`. >> >> If the both tags have the same value for the `text-decoration` property, it >> works without the fix. I'm sure it works with the fix, however, in some >> cases the value of the property may be `line-through,line-through`. >> >> I'll add another test if you think such a scenario is worth verifying too. > > I added the backticks so it now shows the source but all I did was > `"s/<u>/<s>/"` > > Yes, I think it might be wise to add such a test scenario.
Added `HTMLUnderlineOnly.java` and `HTMLStrikeOnly.java` which test different combinations of setting `underline` and `line-through` values for the `text-decoration` CSS property. These two tests pass with and **without** the fix. This means neither is a regression test for [JDK-8326734](https://bugs.openjdk.org/browse/JDK-8326734). Shall I remove `8326734` from `@bug` tag from the tests? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18550#discussion_r1561360248
