On Thu, 11 Apr 2024 09:33:09 GMT, Alexey Ivanov <[email protected]> wrote:
> This clean-up PR removes unused Windows version macro from `ShellFolder2.cpp`. > > `IS_WINVISTA` was not used at all. > > `IS_WINXP` guarded support for icons with alpha channel. It is now safe to > assume Java runs on a Windows version later than Windows XP. Java launchers > specify 6.0 as the minimum OS version which corresponds to Windows Vista. src/java.desktop/windows/native/libawt/windows/ShellFolder2.cpp line 131: > 129: #ifndef IS_WINVISTA > 130: #define IS_WINVISTA (!(::GetVersion() & 0x80000000) && > LOBYTE(LOWORD(::GetVersion())) >= 6) > 131: #endif there are exactly the same macro in awt.h which are mostly unused except "IS_WIN8" ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18736#discussion_r1566819367
