On Mon, 6 May 2024 20:51:55 GMT, Sergey Bylokhov <s...@openjdk.org> wrote:
> The new test to cover the https://bugs.openjdk.org/browse/JDK-8326661 and > verify that the cmm id of the icc profile is properly reported. Before > JDK-8321489 we always report 'lcms' as a cmm id. Marked as reviewed by aivanov (Reviewer). test/jdk/java/awt/color/ICC_Profile/CustomCMMID.java line 30: > 28: /** > 29: * @test > 30: * @bug 8331746 Should `@bug` rather contain the bug id of the bug where this change occurred? Specifically, [8321489](https://bugs.openjdk.org/browse/JDK-8321489) under which LCMS was updated to 2.16. [8326661](https://bugs.openjdk.org/browse/JDK-8326661) may also be included. test/jdk/java/awt/color/ICC_Profile/CustomCMMID.java line 37: > 35: private static final byte[] JAVA_ID = new byte[]{ > 36: (byte) 'j', (byte) 'a', (byte) 'v', (byte) 'a', > 37: }; Suggestion: private static final byte[] JAVA_ID = { (byte) 'j', (byte) 'a', (byte) 'v', (byte) 'a', }; You may omit `new byte[]` like you did below in declaration of `CS`. ------------- PR Review: https://git.openjdk.org/jdk/pull/19110#pullrequestreview-2050726735 PR Review Comment: https://git.openjdk.org/jdk/pull/19110#discussion_r1597141546 PR Review Comment: https://git.openjdk.org/jdk/pull/19110#discussion_r1597138417
