On Sat, 11 May 2024 17:52:28 GMT, Nizar Benalla <d...@openjdk.org> wrote:
> If you're currently reviewing this PR, thank you! > Most fixes here are according to the reports by the since checker tool in > #18934 and are pretty simple. > > To make reviewing easier > - `BasicSliderUI` has the constructor `public BasicSliderUI(JSlider b)` for a > long time so the default constructor (without parameters) didn't exist until > JDK 16 > > For the `package-info` files, it is pretty hard to find source code of JDK > 1-5 so I used the `grep` command to find the oldest instance of an `@since` > in those packages. > > I found instances of `@since 1.1` in the other packages but > `javax/swing/plaf/synth/package-info.java` might be worth checking as most > classes there had no `@since`. I'm not sure I understand the methodology here. I think there must be hundreds of similar missing tags and this seems to be just a few random ones that aren't always correct. src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSliderUI.java line 154: > 152: * Constructs a {@code BasicSliderUI}. > 153: * > 154: * @since 16 Hmm, the *explicit* default constructor was added in JDK 16, but it was implicit before then. So I am not 100% sure what the right answer is - the same as the class, or when it was explicitly added. ------------- PR Comment: https://git.openjdk.org/jdk/pull/19192#issuecomment-2111206725 PR Review Comment: https://git.openjdk.org/jdk/pull/19192#discussion_r1600699721