On Wed, 29 May 2024 06:52:52 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>> Alexander Scherbatiy has updated the pull request incrementally with four >> additional commits since the last revision: >> >> - Move OutputBin import before PageRanges in RasterPrinterJob >> - Add item listener to cbOutput only if the cbOutput is enabled >> - Add messages if no print service is found or OutputBin category is not >> supported >> - Move OutputBin import before PageRanges in CPrinterJob.java > > src/java.desktop/share/classes/sun/print/PSPrinterJob.java line 1652: > >> 1650: } >> 1651: if ((pFlags & OPTIONS) != 0) { >> 1652: for(String option: options.trim().split(" ")) { > > code formatting..space between for and ( code formatting is updated. > src/java.desktop/share/classes/sun/print/PSPrinterJob.java line 1677: > >> 1675: } >> 1676: if ((pFlags & OPTIONS) != 0) { >> 1677: for(String option: options.trim().split(" ")) { > > space is needed for coding style guideline between for and { updated. > src/java.desktop/unix/classes/sun/print/CUPSPrinter.java line 42: > >> 40: import javax.print.attribute.standard.MediaSize; >> 41: import javax.print.attribute.standard.MediaTray; >> 42: import javax.print.attribute.standard.OutputBin; > > Import sorting improper...Should be after MediaPrintableArea and before > PrinterResolution The OutputBin import is updated. > test/jdk/javax/print/attribute/CheckSupportedOutputBinsTest.java line 34: > >> 32: /* >> 33: * @test >> 34: * @bug JDK-8314070 > > should be just bugid `JDK-` prefix is removed. > test/jdk/javax/print/attribute/OutputBinAttributePrintDialogTest.java line 60: > >> 58: /* >> 59: * @test >> 60: * @bug JDK-8314070 > > only bugid is needed updated. > test/jdk/javax/print/attribute/OutputBinAttributeTest.java line 58: > >> 56: /* >> 57: * @test >> 58: * @bug JDK-8314070 > > same here only bugid needed updated. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16166#discussion_r1619429560 PR Review Comment: https://git.openjdk.org/jdk/pull/16166#discussion_r1619429888 PR Review Comment: https://git.openjdk.org/jdk/pull/16166#discussion_r1619430155 PR Review Comment: https://git.openjdk.org/jdk/pull/16166#discussion_r1619430498 PR Review Comment: https://git.openjdk.org/jdk/pull/16166#discussion_r1619430650 PR Review Comment: https://git.openjdk.org/jdk/pull/16166#discussion_r1619430747