On Tue, 28 May 2024 02:25:46 GMT, Alexander Zvegintsev <azveg...@openjdk.org> wrote:
> Some of the modal tests fail in X11 compatibility mode on Wayland, because a > mouse click emulated with XTEST does not not cause the windows to be > reordered. > > This is a known limitation because these click events do not leave the > XWayland server and are not reported to the Wayland compositor. > > There is a [libei](https://gitlab.freedesktop.org/libinput/libei) that can be > used to emulate input events in Wayland. > And there is a [bridge that allows emulated events from XTEST to be passed to > the > compositor](https://gitlab.freedesktop.org/libinput/libei/-/blob/main/README.md?ref_type=heads#xwayland-and-xtest). > Support for this has been added in [Gnome 45 and XWayland > 23.2](https://gitlab.gnome.org/GNOME/mutter/-/issues/3194#note_1937109), but > it is optional and not yet enabled in Ubuntu. > > This change adds `toFront` calls for mouse clicks that are only intended to > bring a window to the front in the window stacking order. > > The testing is green on all platforms. Looks good. ------------- Marked as reviewed by kizune (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/19417#pullrequestreview-2092939542