On Tue, 4 Jun 2024 14:46:37 GMT, Abhishek Kumar <abhis...@openjdk.org> wrote:
>> src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java
>> line 1:
>>
>>> 1: /*
>>
>> You should update the copyright year.
>
> Updated.
I can't see it in the PR. Didn't push?
>> test/jdk/com/sun/java/swing/plaf/gtk/bug6492108.java line 148:
>>
>>> 146: if (refPixel != testPixel) {
>>> 147: fail("Image comparison failed at (" +
>>> 148: x + "," + y + ") for image " + index);
>>
>> Adding `count` and `k` to diagnostic message could help identifying the
>> failing case quicker.
>
> Don't find adding `k` to diagnostic message useful.. failure message is more
> relevant now about the images which are compared.
The images themselves are more useful for sure. Thanks!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19381#discussion_r1626209941
PR Review Comment: https://git.openjdk.org/jdk/pull/19381#discussion_r1626214172
