On Fri, 7 Jun 2024 22:46:44 GMT, Damon Nguyen <dngu...@openjdk.org> wrote:

> This issue is responsible for updating the translations of all the 
> localize(able) resources in the JDK. Primarily, the changes between JDK 22 
> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
> 
> The translation tool adjusted some definitions, which causes some changes in 
> localized files where the source file had no changes. This causes some words 
> being reverted from localized languages to English, and some had its 
> definitions changed.
> 
> Alternatively, the diffs are viewable here and was generated using John 
> Gibbon's diff tool for l10n:
> https://cr.openjdk.org/~dnguyen/output2/

Just a question about the reverted translations, otherwise LGTM

> The translation tool adjusted some definitions, which causes some changes in 
> localized files where the source file had no changes. This causes some words 
> being reverted from localized languages to English, and some had its 
> definitions changed.

Any particular reason you know that the tool had the definitions adjusted? I 
see some of the changes look like like command line options not being 
translated, but it's a bit hard to tell. Do you know if the reverted words 
should be translated (and possibly will be re-translated in future drops?) or 
should they be left untranslated?

-------------

PR Review: https://git.openjdk.org/jdk/pull/19609#pullrequestreview-2105526180
PR Comment: https://git.openjdk.org/jdk/pull/19609#issuecomment-2155723513

Reply via email to