On Wed, 19 Jun 2024 08:38:33 GMT, Abhishek Kumar <abhis...@openjdk.org> wrote:

> Test failed intermittently on Ubuntu 20.04, Ubuntu 22.04 system. Added a 
> delay to stable the test and multiple run in CI is Ok. Link is added in JBS.

You should ask Vitaly to test your changeset in his environment to confirm the 
failure is gone.

test/jdk/com/sun/java/swing/plaf/gtk/bug6492108.java line 113:

> 111:         }
> 112:         setDelay(50);
> 113:         return panel;

How does it help? You're delaying EDT.

You should rather call 
[`setDelay(50)`](https://github.com/openjdk/jdk/blob/50bed6c67b1edd7736bdf79308d135a4e1047ff0/test/jdk/javax/swing/regtesthelpers/SwingTestHelper.java#L284-L294)
 to add the delay between method calls.

Alternatively, you can add `-delay 50` to [the test 
arguments](https://github.com/openjdk/jdk/blob/50bed6c67b1edd7736bdf79308d135a4e1047ff0/test/jdk/javax/swing/regtesthelpers/SwingTestHelper.java#L460-L467)
 in its `@run` tag.

-------------

PR Review: https://git.openjdk.org/jdk/pull/19788#pullrequestreview-2127884342
PR Review Comment: https://git.openjdk.org/jdk/pull/19788#discussion_r1645934622

Reply via email to