On Tue, 9 Jul 2024 12:35:04 GMT, Abhishek Kumar <[email protected]> wrote:
>> The issue is due to the preferred width of the toggle button in GTK L&F for
>> GTK3 only.
>> Comparing the preferred width of toggle button with GTK2 or other LAF, it is
>> much higher in GTK3. The difference is due to the insets value in GTK3.
>>
>> In SwingSet2 demo there are as many as 16 demos are added in toolbar and the
>> preferred width of frame is set to 720px.
>> In GTK L&F (For GTK3), overall preferred width of toolbar is ~980 px which
>> is more than frame width and that results in the clipping of last few demos.
>> In other L&F and GTK2, the preferred width of toolbar is less than frame
>> width. Hence, there is no clipping.
>>
>> The proposed solution is to increase the width and height of SwingSet2 demo
>> frame.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Frame size change for GTK L&F only
src/demo/share/jfc/SwingSet2/SwingSet2.java line 852:
> 850: } else {
> 851: if (currentLookAndFeel.name.contains("GTK")) {
> 852: frame.setSize(980, 870);
why do you update the size here instead of above where the original code sets
the preferred size of the demo?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20052#discussion_r1672951954
