On Wed, 24 Jul 2024 09:17:47 GMT, Abhishek Kumar <[email protected]> wrote:
>> This test was modified under >> [JDK-8328403](https://bugs.openjdk.org/browse/JDK-8328403) bug to remove the >> applet usage. Test modification includes the instruction change as well >> which says that `Check that there is a panel with "Text Preview Panel" text >> and with title "Preview" in the JColorChooser`. Applet test didn't say >> explicitly about the panel title. >> >> When the test is run with `GTKLookAndFeel` option, `Preview` title is >> missing due to the `showPreviewPanelText` property defined for >> `GTKLookAndFeel` is set to **FALSE**. `showPreviewPanelText` property is not >> defined for other L&Fs and that leads to fallback to the default value of >> **TRUE** for the property while lookup. >> >> Proposed fix is to change the default value of `showPreviewPanelText` >> property to **TRUE** for GTK L&F. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the last revision: > > Review comment fix Since the PR has changed to just be a test fix and no longer includes the product change, it looks safer as a change altogether. Changes look good, but I found some grammatical errors. Fix these and it looks good. test/jdk/javax/swing/JColorChooser/Test6977726.java line 48: > 46: Note: "Preview" title is not applicable for GTK Look and > Feel."""; > 47: > 48: // In case if this test is run with GTK L&F, the preview panel > title Suggestion: // In case this test is run with GTK L&F, the preview panel title Minor grammar change. test/jdk/javax/swing/JColorChooser/Test6977726.java line 51: > 49: // is missing due to the "ColorChooser.showPreviewPanelText" > property > 50: // which is set to "Boolean.FALSE" for GTK L&F. Test instructions > are > 51: // modified to reflet that "Preview" title is not applicable for > GTK L&F. Suggestion: // modified to reflect that "Preview" title is not applicable for GTK L&F. ------------- Marked as reviewed by dnguyen (Committer). PR Review: https://git.openjdk.org/jdk/pull/20104#pullrequestreview-2199821688 PR Review Comment: https://git.openjdk.org/jdk/pull/20104#discussion_r1691780363 PR Review Comment: https://git.openjdk.org/jdk/pull/20104#discussion_r1691781069
