On Wed, 24 Jul 2024 19:14:00 GMT, Alexey Ivanov <[email protected]> wrote:

>> Ravi Gupta has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   8333403: Review commnets fixed
>
> test/jdk/java/awt/event/ComponentEvent/ComponentEventTest.java line 191:
> 
>> 189: 
>> 190:         robot.delay(DELAY);
>> 191:         if (componentShown || componentHidden) {
> 
> Is it possible that any other event is triggered? Or do you expect other 
> events?
> 
> When you inconify the frame, you verify of all the event flags but you verify 
> only two flags here.

Here we expect events should not triggered.

When inconify i expect all events should not triggered , but when form 
Frame.ICONIFIED to Frame.NORMAL componentMoved and componentResized events are 
triggered , Events order on Windows and Mac are different.

Order of the events for Frame from Frame.ICONIFIED to Frame.NORMAL

On Windows

Component Shown 
Frame is Visible with ExtendedState as ICONIFIED
Component Moved
Component Resized
Frame is Visible with ExtendedState as NORMAL

On MAC
Component Moved
Component Resized
Component Shown 
Frame is Visible with ExtendedState as ICONIFIED
Frame is Visible with ExtendedState as NORMAL

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19521#discussion_r1703998938

Reply via email to