On Wed, 18 Sep 2024 12:38:34 GMT, Abhishek Kumar <[email protected]> wrote:
>> Few AWT MenuItem related tests are converted from applet to manual and moved >> to open. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the last revision: > > added requires jtreg tag The instructions now look good to me. There are lots of trailing whitespace characters though. test/jdk/java/awt/MenuItem/GiantFontTest.java line 2: > 1: /* > 2: * Copyright (c) 2007, 2024, Oracle and/or its affiliates. All rights > reserved. Suggestion: * Copyright (c) 2002, 2024, Oracle and/or its affiliates. All rights reserved. This test was written in 2002 for [JDK-4700350](https://bugs.openjdk.org/browse/JDK-4700350). Could you also add `@bug 4700350` to jtreg tags? https://github.com/openjdk/jdk/blob/ae39a6603c6c33a36dce30c3290a634b08a6bf05/src/java.desktop/windows/native/libawt/windows/awt_MenuItem.cpp#L513-L516 ------------- Changes requested by aivanov (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/21029#pullrequestreview-2312945687 PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1765206356
