On Wed, 18 Sep 2024 23:40:16 GMT, Harshitha Onkar <[email protected]> wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comment fix
>
> test/jdk/java/awt/Frame/FrameSetMinimumSizeTest.java line 61:
>
>> 59: if (!passed) {
>> 60: throw new RuntimeException("Frame's setMinimumSize not
>> honoured");
>> 61: }
>
> The test condition does not seem right.
> For instance if `passed` was false in one of the previous checks and the
> final case results in true then the test passes, which seems to be incorrect.
Yes, you are right. Modified the condition to check after every frame resize.
> test/jdk/java/awt/Frame/FrameSetMinimumSizeTest.java line 80:
>
>> 78: private static boolean verifyFrameSize(Dimension expected) {
>> 79:
>> 80: if (f.getSize().width != expected.width || f.getSize().height !=
>> expected.height) {
>
> Do we need to wrap calls to `verifyFrameSize()` in EDT, since we are
> accessing frame.getSize() ?
Updated.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21052#discussion_r1766177491
PR Review Comment: https://git.openjdk.org/jdk/pull/21052#discussion_r1766177586
