On Thu, 19 Sep 2024 14:55:39 GMT, Alexey Ivanov <[email protected]> wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Test restructured and test frames set visible true
>
> test/jdk/java/awt/MenuItem/LotsOfMenuItemsTest.java line 94:
>
>> 92: }
>> 93:
>> 94: public TestFrame(String title, boolean visible) {
>
> You'll need a constructor which accepts `x` and `y`:
> Suggestion:
>
> public TestFrame(String title) {
> this(title, 0, 0, false);
> }
>
> public TestFrame(String s, int x, int y) {
> this(s, x, y, true);
> }
>
> private TestFrame(String title,
> int x, int y,
> boolean visible) {
>
>
> Then you'll call `setLocation(x, y);` before calling `setSize`.
Most of these comments are already resolved, except for
> `testFrame` field is no longer needed, it can be a local variable in
> `componentShown`.
I discussed it with Abhishek privately but I forgot to click the *Submit*
button to post them.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1767098803
