On Mon, 30 Sep 2024 03:38:37 GMT, Prasanta Sadhukhan <[email protected]>
wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments
>
> test/jdk/java/awt/MenuBar/MenuBarAddRemoveTest/MenuBarAddRemoveTest.java line
> 28:
>
>> 26: * @bug 4028130 4112308
>> 27: * @summary Disabling a frame does not disable the menus on the frame, on
>> 28: * solaris/linux
>
> seems summary is wrong for this test...
Good catch. Test didn't have one originally, and I missed it. Added, thanks.
> test/jdk/java/awt/MenuBar/MenuBarVisuals/MenuBarVisuals.java line 63:
>
>> 61:
>> 62: private static Frame createUI() {
>> 63: Frame f = new Frame("Test frame");
>
> meaningful frame name can be given...
Updated
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21251#discussion_r1781458161
PR Review Comment: https://git.openjdk.org/jdk/pull/21251#discussion_r1781457673
