On Mon, 30 Sep 2024 16:51:04 GMT, Harshitha Onkar <hon...@openjdk.org> wrote:
> Following tests are open-sourced in this PR:
>
> 1. /java/awt/MouseInfo/ContainerResizeMousePositionTest.java - Automated
> 2. [LINUX ONLY] /java/awt/color/XAWTDifference/XAWTDifference.java - Manual
> PFJ test
Changes requested by aivanov (Reviewer).
test/jdk/java/awt/MouseInfo/ContainerResizeMousePositionTest.java line 95:
> 93:
> 94: if (!eventCaught.await(2, TimeUnit.SECONDS)) {
> 95: if (!testSucceeded) {
These two conditions look independent.
If `eventCaught.await` returned `false`, the test should fail with a timeout.
Otherwise, the test fails if `testSucceeded` didn't become `true`.
-------------
PR Review: https://git.openjdk.org/jdk/pull/21271#pullrequestreview-2338223302
PR Review Comment: https://git.openjdk.org/jdk/pull/21271#discussion_r1781527179
