On Thu, 3 Oct 2024 11:31:47 GMT, Abhishek Kumar <abhis...@openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Apply suggestions from code review
>>   
>>   Co-authored-by: Abhishek Kumar <abhishek.cx.ku...@oracle.com>
>
> test/jdk/java/awt/Desktop/ActionSupportTest/ActionSupportTest.java line 49:
> 
>> 47:             System.out.println("Class java.awt.Desktop is not supported 
>> on " +
>> 48:                     "current platform. Farther testing will not be 
>> performed");
>> 49:             return;
> 
> May use jtreg skipped Exception.

Sure. Fixing.

> test/jdk/java/awt/Desktop/OpenTest/OpenTest.java line 27:
> 
>> 25:  * @test
>> 26:  * @bug 6255196
>> 27:  * @key headful
> 
> `headful` tag is redundant for manual test.

Removing.

> test/jdk/java/awt/Desktop/OpenTest/OpenTest.java line 29:
> 
>> 27:  * @key headful
>> 28:  * @summary Verifies the function of method open(java.io.File file).
>> 29:  * @library /open/test/jdk/java/awt/regtesthelpers
> 
> Please remove leading `/open/test/jdk`

Fixing now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21321#discussion_r1786838676
PR Review Comment: https://git.openjdk.org/jdk/pull/21321#discussion_r1786839964
PR Review Comment: https://git.openjdk.org/jdk/pull/21321#discussion_r1786840128

Reply via email to