On Mon, 14 Oct 2024 17:27:25 GMT, Abhishek Kumar <abhis...@openjdk.org> wrote:
>> Alexey Ivanov has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Rename instructions -> INSTRUCTIONS
>> - Add @library and @build jtreg tags
>
> test/jdk/javax/swing/JButton/TimeChangeButtonClickTest.java line 29:
>
>> 27: * @summary Test that Swing does not ignore first click on a JButton
>> after
>> 28: * decreasing system's time
>> 29: * @run main/manual TimeChangeButtonClickTest
>
> Please add jtreg tags to avoid compilation error.
> `@library /java/awt/regtesthelpers` and `@build PassFailJFrame`
Good catch! I forgot to add them.
> test/jdk/javax/swing/JButton/TimeChangeButtonClickTest.java line 45:
>
>> 43:
>> 44: public class TimeChangeButtonClickTest {
>> 45: private static final String instructions = """
>
> Suggestion:
>
> private static final String INSTRUCTIONS = """
It's not required, only public constants are in upper case by convention. Yet
most private constants use upper case for the name, and most tests follow this
convention.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21476#discussion_r1799935925
PR Review Comment: https://git.openjdk.org/jdk/pull/21476#discussion_r1799937085
