On Wed, 6 Nov 2024 11:31:04 GMT, Renjith Kannath Pariyangad
<[email protected]> wrote:
> Hi Reviewers,
>
> I have added the test tag **@requires os.family != "mac"** and updated
> section with new format.
> Removed OSX check condition form the code.
>
> Please review and let me know your suggestions if any.
Changes requested by aivanov (Reviewer).
test/jdk/java/awt/List/KeyEventsTest/KeyEventsTest.java line 44:
> 42: /*
> 43: * @test
> 44: * @key headful
Suggestion:
/*
* @test
* @key headful
Align asterisks to the asterisk on the opening line.
test/jdk/java/awt/List/KeyEventsTest/KeyEventsTest.java line 267:
> 265: boolean isWin = false;
> 266: if (Platform.isWindows()) {
> 267: isWin = true;
Can be simplified to
Suggestion:
boolean isWin = Platform.isWindows();
-------------
PR Review: https://git.openjdk.org/jdk/pull/21924#pullrequestreview-2418718193
PR Review Comment: https://git.openjdk.org/jdk/pull/21924#discussion_r1831279065
PR Review Comment: https://git.openjdk.org/jdk/pull/21924#discussion_r1831279864
