Re: RFR: 8150564: Migrate useful ExtendedRobot methods into awt.Robot

[Phil Race]

On Tue, 12 Nov 2024 17:39:55 GMT, Alisen Chung <ach...@openjdk.org> wrote:

> Some useful methods in ExtendedRobot should be migrated into Robot itself so 
> that ExtendedRobot can be removed in the future. The tests using 
> ExtendedRobot for these migrated methods are changed to use only Robot 
> (removing unnecessary building of ExtendedRobot).

Please resolve the merge conflict.

src/java.desktop/share/classes/java/awt/Robot.java line 805:

> 803:      */
> 804:     public void click(int buttons) {
> 805: //        throw new RuntimeException("click");

get rid of the comments.
Also you need @since  tags on the new methods

src/java.desktop/share/classes/java/awt/Robot.java line 826:

> 824:      */
> 825:     public void click() {
> 826: //        throw new RuntimeException("click");

same

src/java.desktop/share/classes/java/awt/Robot.java line 841:

> 839:      */
> 840:     public synchronized void waitForIdle(int delayValue) {
> 841: //        throw new RuntimeException("waitForIdle");

same .. I'm not going to point them all out, just fix them

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22044#issuecomment-2474612657
PR Review Comment: https://git.openjdk.org/jdk/pull/22044#discussion_r1841073397
PR Review Comment: https://git.openjdk.org/jdk/pull/22044#discussion_r1841073832
PR Review Comment: https://git.openjdk.org/jdk/pull/22044#discussion_r1841074366