On Wed, 27 Nov 2024 04:26:18 GMT, Prasanta Sadhukhan <[email protected]> wrote:
>> The fix for [JDK-8226990](https://bugs.openjdk.org/browse/JDK-8226990) >> causes regression in dark theme for GTK L&F on Ubuntu system and that >> results in manual test failures identified recently. >> >> Few of the changes made in >> [JDK-8226990](https://bugs.openjdk.org/browse/JDK-8226990) is further >> modified in [JDK-8335130](https://bugs.openjdk.org/browse/JDK-8335130). >> >> Backing out the overall fix to prevent any regression. >> >> CI testing after revert is fine. > > src/java.desktop/share/classes/javax/swing/plaf/synth/SynthTabbedPaneUI.java > line 149: > >> 147: @Override >> 148: protected void installDefaults() { >> 149: updateStyle(tabPane); > > guess you missed adding this back > tabsOpaque = UIManager.getBoolean("TabbedPane.tabsOpaque"); ok..I guess I am wrong.. > src/java.desktop/share/classes/javax/swing/plaf/synth/SynthTabbedPaneUI.java > line 640: > >> 638: } >> 639: >> 640: >> tabContext.getPainter().paintTabbedPaneTabBackground(tabContext, g, > > and this > if (tabsOpaque || tabPane.isOpaque()) { it is not needed ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22379#discussion_r1859873170 PR Review Comment: https://git.openjdk.org/jdk/pull/22379#discussion_r1859874064
