On Wed, 4 Dec 2024 15:40:31 GMT, Alexey Ivanov <[email protected]> wrote:

> This is a continuation to #20376, it moves the text in 
> `Document-{insert,remove}.svg` down by 0.5 pixel.
> 
> This change makes the text centred in the boxes.
> 
> Here are quotes from 
> https://github.com/openjdk/jdk/pull/20376#issuecomment-2353728939 and 
> https://github.com/openjdk/jdk/pull/20376#issuecomment-2353743533:
> 
>> <q 
>> cite="https://github.com/openjdk/jdk/pull/20376#issuecomment-2353728939";>At 
>> 200% scale and Arial font, there are 6 pixels on top of ‘T’ and ‘h’, but 
>> there are 8 pixels on the bottom of ‘q’.</q>
>> 
>> <q 
>> cite="https://github.com/openjdk/jdk/pull/20376#issuecomment-2353743533";>Moving
>>  the text position by 0.5 seems to help, and the values become equal: 7 on 
>> either side.</q>

Marked as reviewed by azvegint (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/22549#pullrequestreview-2479176022

Reply via email to