On Mon, 9 Dec 2024 07:00:19 GMT, Prasanta Sadhukhan <[email protected]>
wrote:
>> javax/swing/JSplitPane/4164779/JSplitPaneKeyboardNavigationTest.java fails
>> in ubuntu22.04 citing
>>
>>
>> Verifier 1 failed, rightButton2 is not focus owner,F6 doesn't transfer focus
>> to the right/bottom side of the splitpane
>> Verifier 2 passed
>> Verifier 3 passed
>> Verifier 4 passed
>> ----------System.err:(11/842)----------
>> java.lang.RuntimeException: Test failed, verifiers 1, failed for
>> com.sun.java.swing.plaf.motif.MotifLookAndFeel
>>
>>
>> seems like focus is not transferred in time but is very intermittent...Added
>> stability fixes with waitForIdle, delay and test passed in several OCI
>> systems without issue
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Review
Apart from the following suggestions, test changes LGTM and work as expected on
x11 & wayland.
Ln#174: Is it better to move the button click to the center of the btn for
stability?
robot.mouseMove(buttonLoc.x + button.getWidth() / 2,
buttonLoc.y + button.getHeight() / 2);
Ln#230: `frame = null` is not required in disposeFrame() and can be removed.
-------------
Marked as reviewed by honkar (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22631#pullrequestreview-2489974117
