On Wed, 13 Nov 2024 21:56:16 GMT, Damon Nguyen <[email protected]> wrote:
>> I notice one more cursor type (resize cursor?) in between the "move" panel >> and the panel containing the crosshair button and hand panel. I think it's >> caused by the JSplitPane resizing option. Since this test is about checking >> different cursor types while hovering parts of the frame, it might be worth >> either adding this cursor to the instructions or setting the JSplitPane to >> not be resizable to remove the cursor. > >> I notice one more cursor type (resize cursor?) in between the "move" panel >> and the panel containing the crosshair button and hand panel. I think it's >> caused by the JSplitPane resizing option. Since this test is about checking >> different cursor types while hovering parts of the frame, it might be worth >> either adding this cursor to the instructions or setting the JSplitPane to >> not be resizable to remove the cursor. > > I saw this when initially converting the test, but since the original bug > description and the test summary is checking for the functionality of > `setCursor()`, I don't think it's worth adding a check for the resize cursor. > > But I realized that the frame's wait cursor works on all OS's and the frame > isn't part of the original test instructions anyway, so I repurposed the wait > cursor for the pane instead. Simplifies the instructions too. > @DamonGuy Tested on windows and it works as expected, does the test > instructions hold good on all platforms ? Yup! Changed the cursor types so they're applicable on all platforms. Thanks ------------- PR Comment: https://git.openjdk.org/jdk/pull/22055#issuecomment-2533141746
